Create methods: HTTP body
This rule enforces that all Create
RPCs set the HTTP body
to the resource,
as mandated in AIP-133.
Details
This rule looks at any message matching beginning with Create
, and complains
if the HTTP body
field is not set to the resource being created.
Note that any additional_bindings
need their own body
field.
Examples
Incorrect code for this rule:
// Incorrect.
rpc CreateBook(CreateBookRequest) returns (Book) {
option (google.api.http) = {
post: "/v1/{parent=publishers/*}/books"
body: "*" // This should be "book".
};
}
// Incorrect.
rpc CreateBook(CreateBookRequest) returns (Book) {
option (google.api.http) = {
post: "/v1/{parent=publishers/*}/books"
body: "book"
additional_bindings: {
post: "/v1/books"
// There should be a "body" here too.
}
};
}
Correct code for this rule:
// Correct.
rpc CreateBook(CreateBookRequest) returns (Book) {
option (google.api.http) = {
post: "/v1/{parent=publishers/*}/books"
body: "book"
};
}
// Correct.
rpc CreateBook(CreateBookRequest) returns (Book) {
option (google.api.http) = {
post: "/v1/{parent=publishers/*}/books"
body: "book"
additional_bindings: {
post: "/v1/books"
body: "book"
}
};
}
Disabling
If you need to violate this rule, use a leading comment above the method. Remember to also include an aip.dev/not-precedent comment explaining why.
// (-- api-linter: core::0133::http-body=disabled
// aip.dev/not-precedent: We need to do this because reasons. --)
rpc CreateBook(CreateBookRequest) returns (Book) {
option (google.api.http) = {
post: "/v1/{parent=publishers/*}/books"
body: "*"
};
}
If you need to violate this rule for an entire file, place the comment at the top of the file.