Rollback requests: Revision ID field

This rule enforces that all Rollback methods have a string revision_id field in the request message, as mandated in AIP-162.

Details

This rule looks at any message matching Rollback*Request and complains if either the revision_id field is missing or it has any type other than string.

Examples

Incorrect code for this rule:

// Incorrect.
// Should include a `string revision_id` field.
message RollbackBookRequest {
  string name = 1 [
    (google.api.field_behavior) = REQUIRED,
    (google.api.resource_reference).type = "library.googleapis.com/Book"
  ];
}

// Incorrect.
message RollbackBookRequest {
  string name = 1 [
    (google.api.field_behavior) = REQUIRED,
    (google.api.resource_reference).type = "library.googleapis.com/Book"
  ];

  // Field type should be `string`.
  bytes revision_id = 2 [(google.api.field_behavior) = REQUIRED];
}

Correct code for this rule:

// Correct.
message RollbackBookRequest {
  string name = 1 [
    (google.api.field_behavior) = REQUIRED,
    (google.api.resource_reference).type = "library.googleapis.com/Book"
  ];

  string revision_id = 2 [(google.api.field_behavior) = REQUIRED];
}

Disabling

If you need to violate this rule, use a leading comment above the message (if the name field is missing) or above the field (if it is the wrong type). Remember to also include an aip.dev/not-precedent comment explaining why.

message RollbackBookRequest {
  string name = 1 [
    (google.api.field_behavior) = REQUIRED,
    (google.api.resource_reference).type = "library.googleapis.com/Book"
  ];

  // (-- api-linter: core::0162::rollback-request-revision-id-field=disabled
  //     aip.dev/not-precedent: We need to do this because reasons. --)
  bytes revision_id = 2 [(google.api.field_behavior) = REQUIRED];
}

If you need to violate this rule for an entire file, place the comment at the top of the file.